--- loncom/interface/lonpopulate.pm	2009/03/25 15:49:47	1.58
+++ loncom/interface/lonpopulate.pm	2010/01/22 13:20:04	1.62.4.2
@@ -1,5 +1,5 @@
 # automated enrollment configuration handler
-# $Id: lonpopulate.pm,v 1.58 2009/03/25 15:49:47 bisitz Exp $
+# $Id: lonpopulate.pm,v 1.62.4.2 2010/01/22 13:20:04 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -370,13 +370,13 @@ ENDONE
 ENDTWO
       if ($enrollvar{autoadds}) {
           $r->print("
-			    <label><input type=\"radio\" name=\"autoadds\" value=\"1\" checked=\"true\" />&nbsp;Enable&nbsp;&nbsp;&nbsp;</label>
+			    <label><input type=\"radio\" name=\"autoadds\" value=\"1\" checked=\"checked\" />&nbsp;Enable&nbsp;&nbsp;&nbsp;</label>
 			    <label><input type=\"radio\" name=\"autoadds\" value=\"0\" />&nbsp;Disable</label>
          ");
       } else {
           $r->print("
                             <label><input type=\"radio\" name=\"autoadds\" value=\"1\" />&nbsp;Enable&nbsp;&nbsp;&nbsp;</label>
-                            <label><input type=\"radio\" name=\"autoadds\" value=\"0\" checked=\"true\" />&nbsp;Disable</label>
+                            <label><input type=\"radio\" name=\"autoadds\" value=\"0\" checked=\"checked\" />&nbsp;Disable</label>
          ");
       }
       $r->print("
@@ -387,12 +387,12 @@ ENDTWO
  	       Removals based on classlist changes:&nbsp;&nbsp;");
       if ($enrollvar{autodrops}) {
           $r->print("
-                <label><input type=\"radio\" name=\"autodrops\" value=\"1\" checked=\"true\" />&nbsp;Enable&nbsp;&nbsp;&nbsp;</label>
+                <label><input type=\"radio\" name=\"autodrops\" value=\"1\" checked=\"checked\" />&nbsp;Enable&nbsp;&nbsp;&nbsp;</label>
                 <label><input type=\"radio\" name=\"autodrops\" value=\"0\" />&nbsp;Disable</label>");
       } else {
           $r->print("
                 <label><input type=\"radio\" name=\"autodrops\" value=\"1\" />&nbsp;Enable&nbsp;&nbsp;&nbsp;</label>
-                <label><input type=\"radio\" name=\"autodrops\" value=\"0\" checked=\"true\" />&nbsp;Disable</label>");
+                <label><input type=\"radio\" name=\"autodrops\" value=\"0\" checked=\"checked\" />&nbsp;Disable</label>");
       }
       $r->print("
               </td>
@@ -508,8 +508,7 @@ ENDTWO
   } elsif ($action eq "notify") {
       my $notifycount = 0;
       my @notified = split(/,/,$enrollvar{notifylist});
-      my @domcoord;
-      my @showdom;
+      my (@domcoord,@showdom,@olddomcoord,@futuredomcoord);
       for (my $i=0; $i<@notified; $i++) {
           if ($notified[$i] !~ /:/) {
               $notified[$i] =~ s/\@/:/;
@@ -522,12 +521,26 @@ ENDTWO
       } else {
           $noteset = "OFF";
       }
+      my $now = time;
       my %dompersonnel = &Apache::lonnet::get_domain_roles($dom,['dc']);
       foreach my $server (keys(%dompersonnel)) {
           foreach my $user (sort(keys(%{$dompersonnel{$server}}))) {
               my ($trole,$uname,$udom,$runame,$rudom,$rsec) = split(/:/,$user);
-              if (!grep(/^$uname:$udom$/,@domcoord)) {
-                  push(@domcoord,$uname.':'.$udom);
+              my ($end,$start) = split(':',$dompersonnel{$server}{$user});
+              if (($end eq '') || ($end == 0) || ($end > $now)) {
+                  if ($start > $now) {
+                      if (!grep(/^\Q$uname\E:\Q$udom\E$/,@futuredomcoord)) {
+                          push(@futuredomcoord,$uname.':'.$udom);
+                      }
+                  } else {
+                      if (!grep(/^\Q$uname\E:\Q$udom\E$/,@domcoord)) {
+                          push(@domcoord,$uname.':'.$udom);
+                      }
+                  }
+              } else {
+                  if (!grep(/^\Q$uname\E:\Q$udom\E$/,@olddomcoord)) {
+                      push(@olddomcoord,$uname.':'.$udom);
+                  }
               }
           }
       }
@@ -547,13 +560,13 @@ ENDTWO
       ");
       if ($notifycount) {
           $r->print("
-                        <label><input type=\"radio\" name=\"notify\" value=\"1\" checked=\"true\" />&nbsp;Yes&nbsp;&nbsp;&nbsp;</label>
+                        <label><input type=\"radio\" name=\"notify\" value=\"1\" checked=\"checked\" />&nbsp;Yes&nbsp;&nbsp;&nbsp;</label>
                         <label><input type=\"radio\" name=\"notify\" value=\"0\" />&nbsp;No</label>
           ");
       } else {
           $r->print("
                         <label><input type=\"radio\" name=\"notify\" value=\"1\" />&nbsp;Yes&nbsp;&nbsp;&nbsp;</label>
-                        <label><input type=\"radio\" name=\"notify\" value=\"0\" checked=\"true\" />&nbsp;No</label>
+                        <label><input type=\"radio\" name=\"notify\" value=\"0\" checked=\"checked\" />&nbsp;No</label>
           ");
       }
       $r->print("
@@ -565,7 +578,6 @@ ENDTWO
       my %pname;
       my %notifystate;
       my %status;
-      my $now = time;
       foreach my $person (sort(keys(%coursepersonnel))) {
           my $match = 0;
           my ($role,$user,$usec) = ($person =~ /^([^:]+):([^:]+:[^:]+):([^:]*)/);
@@ -601,6 +613,7 @@ ENDTWO
                                   usnm => 'username:domain',
                                   coac => 'Course Access',
                                   curn => 'Current notification status',
+                                  doms => 'Domain Coordinator status',
                                   notf => 'Notification?',
                                   ntac => 'Notification active',
                                   ntin => 'Notification inactive',
@@ -630,7 +643,7 @@ ENDTWO
       if (grep(/^$viewer$/,@domcoord)) {
           $showalldc = 1;
       }
-      foreach my $dc (@domcoord) {
+      foreach my $dc (@domcoord,@futuredomcoord) {
           if (!grep(/^$dc$/,@ccs)) {
               if (grep(/^$dc$/,@notified)) {
                   $notifystate{$dc} = 1;
@@ -645,6 +658,16 @@ ENDTWO
               push(@showdom,$dc);
           }
       }
+      foreach my $olddc (@olddomcoord) {
+          if (grep(/^$olddc$/,@notified)) {
+              if (!grep(/^\Q$olddc\E$/,@ccs)) {
+                  $notifystate{$olddc} = 1;
+                  my ($dcname,$dcdom) = split(/:/,$olddc);
+                  $pname{$olddc} =  &Apache::loncommon::plainname($dcname,$dcdom);
+                  push(@showdom,$olddc);
+              }
+          }
+      }
       my $showdomnum = scalar(@showdom);
       if ($showdomnum) {
           $r->print("
@@ -662,8 +685,8 @@ ENDTWO
              </tr>
              <tr>
               <td>");
-          $r->print(&notifier_tables('dc',\%lt,\@showdom,\%status,\%notifystate,
-                                     \%pname,\$notifyshow));
+          $r->print(&notifier_tables('dc',\%lt,\@showdom,\%status,\%notifystate,\%pname,
+                                     \$notifyshow,\@olddomcoord,\@futuredomcoord));
           $r->print("
              </td>
           </tr>");
@@ -734,9 +757,9 @@ ENDTWO
               my $colflag = $i%2;
               $r->print(&Apache::loncommon::start_data_table_row());
               $r->print("
-                 <td><input type=\"checkbox\" name=\"cross_$i\" checked=\"true\" /></td>
+                 <td><input type=\"checkbox\" name=\"cross_$i\" checked=\"checked\" /></td>
                  <td>$xl</td>
-                 <td><input type =\"text\" size=\"10\" name=\"lcsec_$i\" value=\"$lc_sec\" /></td>
+                 <td><input type=\"text\" size=\"10\" name=\"lcsec_$i\" value=\"$lc_sec\" /></td>
               ");
               $r->print(&Apache::loncommon::end_data_table_row());
           }
@@ -825,7 +848,7 @@ ENDTWO
                   $r->print("Enrollment inactive");
               }
               if ($shrflag) {
-                  $r->print("</td><td><input type=\"text\" size=\"10\" name=\"loncapasec_$i\" value=\"$sec_id{$sections[$i]}\"></td><td><input type=\"checkbox\" name=\"sec_$i\" checked=\"true\" /></td>"); 
+                  $r->print("</td><td><input type=\"text\" size=\"10\" name=\"loncapasec_$i\" value=\"$sec_id{$sections[$i]}\" /></td><td><input type=\"checkbox\" name=\"sec_$i\" checked=\"checked\" /></td>"); 
               } else {
                   $r->print("</td><td><input type=\"text\" size=\"10\" name=\"loncapasec_$i\" value=\"\" /></td><td><input type=\"checkbox\" name=\"sec_$i\" /></td>");
               }
@@ -874,7 +897,7 @@ ENDTWO
                   my $colflag = $j%2;
                   $r->print(&Apache::loncommon::start_data_table_row());
                   $r->print("
-                 <td><input type=\"checkbox\" name=\"sec_$j\" checked=\"true\" /></td>
+                 <td><input type=\"checkbox\" name=\"sec_$j\" checked=\"checked\" /></td>
                  <td>$currsections[$j]</td>
                  <td><input type=\"text\" name=\"lcsec_$j\" size=\"10\" value=\"$sec_id{$currsections[$j]}\" /></td>
                   ");
@@ -931,13 +954,13 @@ ENDTWO
       ");
       if ($enrollvar{showphoto}) {
           $r->print("
-                        <label><input type=\"radio\" name=\"showphotos\" value=\"1\" checked=\"true\" />&nbsp;Yes&nbsp;&nbsp;&nbsp;</label>
+                        <label><input type=\"radio\" name=\"showphotos\" value=\"1\" checked=\"checked\" />&nbsp;Yes&nbsp;&nbsp;&nbsp;</label>
                         <label><input type=\"radio\" name=\"showphotos\" value=\"0\" />&nbsp;No</label>
           ");
       } else {
           $r->print("
                         <label><input type=\"radio\" name=\"showphotos\" value=\"1\" />&nbsp;Yes&nbsp;&nbsp;&nbsp;</label>
-                        <label><input type=\"radio\" name=\"showphotos\" value=\"0\" checked=\"true\" />&nbsp;No</label>
+                        <label><input type=\"radio\" name=\"showphotos\" value=\"0\" checked=\"checked\" />&nbsp;No</label>
           ");
       }
       $r->print('
@@ -1088,14 +1111,14 @@ Note: Any students previously added manu
           if ($update) { 
               $r->print('<br />'.$commentary.'<br /><br />
 <form name="photoupdate" method="post">
-<input type ="button" name="retrieve" value="'.&mt('Update photo repository').'"
+<input type="button" name="retrieve" value="'.&mt('Update photo repository').'"
 onclick="javascript:document.photoupdate.submit()" />
-<input type ="hidden" name="action" value="'.$action.'" />
-<input type ="hidden" name="state" value="process" />
+<input type="hidden" name="action" value="'.$action.'" />
+<input type="hidden" name="state" value="process" />
 </form>');
           } else {
               $r->print(&mt('Update of photos via the Automated Enrollment Manager is unavailable in this domain.')
-                       .'<br /><br /><input type="button" name=mainmenu" value="'.&mt('Go back').'" onclick="javascript:history.go(-1);" />');
+                       .'<br /><br /><input type="button" name="mainmenu" value="'.&mt('Go back').'" onclick="javascript:history.go(-1);" />');
           }
       } else {
           $r->print('Update of photos is unavailable, as import of student photos is currently disabled.<br />Enable this first via: <a href="/adm/populate?action=photos">'.$$tasktitleref{'photos'}.'</a>');
@@ -1132,7 +1155,8 @@ onclick="javascript:document.photoupdate
       my ($indexhash,$keylist) = &Apache::lonuserutils::make_keylist_array();
       my $classlist = &Apache::loncoursedata::get_classlist();
       my $secidx = &Apache::loncoursedata::CL_SECTION();
-      my ($permission,$allowed) = &Apache::lonuserutils::get_permission();
+      my $crstype =&Apache::loncommon::course_type();
+      my ($permission,$allowed) = &Apache::lonuserutils::get_permission('course',$crstype);
       foreach my $student (keys(%{$classlist})) {
           if (exists($permission->{'view_section'})) {
               if ($classlist->{$student}[$secidx] ne $permission->{'view_section'}) {
@@ -1230,14 +1254,17 @@ END
 }
 
 sub notifier_tables {
-    my ($role,$lt,$users,$status,$notifystate,$pname,$notifyshow) = @_;
+    my ($role,$lt,$users,$status,$notifystate,$pname,$notifyshow,$olddomcoord,
+        $futuredomcoord) = @_;
     my $output = &Apache::loncommon::start_data_table();
     $output .= &Apache::loncommon::start_data_table_header_row();
     $output .= "<th>$$lt{name}</th>
                 <th>$$lt{usnm}</th>";
-    if ($role eq 'cc') {
+    if ($role eq 'dc') {
+        $output .= "<th>$$lt{doms}</th>";
+    } elsif ($role eq 'cc') {
         $output .= "<th>$$lt{coac}</th>";
-    } 
+    }
     $output .=  "<th>$$lt{curn}</th>
                  <th>$$lt{notf}</th>";
     $output .= &Apache::loncommon::end_data_table_header_row();
@@ -1246,7 +1273,19 @@ sub notifier_tables {
         $output .= '<td>'.$$pname{$$users[$i]}.'</td>'.
                    '<td><input type="hidden" name="notifyname_'.$$notifyshow.
                    '" value="'.$$users[$i].'" />'.$$users[$i].'</td>';
-        if ($role eq 'cc') {
+        if ($role eq 'dc') {
+            $output .= '<td>';
+            if ((ref($olddomcoord) eq 'ARRAY') && (ref($futuredomcoord) eq 'ARRAY')) {
+                if (grep(/^\Q$users->[$i]\E$/,@{$olddomcoord})) {
+                    $output .= &mt('expired');
+                } elsif (grep(/^\Q$users->[$i]\E$/,@{$futuredomcoord})) {
+                    $output .= &mt('future');
+                } else {
+                    $output .= &mt('active');
+                }
+            }
+            $output .= '</td>';
+        } elsif ($role eq 'cc') {
             $output .= '<td>'.$$status{$$users[$i]}.'</td>';
         }
         $output .= '<td>';
@@ -2413,10 +2452,10 @@ function agreement_result(caller) {
       </td>
     </tr>
    </table>
-   <input type ="hidden" name="action" value="'.$action.'" />
-   <input type ="hidden" name="state" value="process" />
-   <input type ="hidden" name="showphotos" value="1" />
-   <input type= "hidden" name="photopermission" value="" />
+   <input type="hidden" name="action" value="'.$action.'" />
+   <input type="hidden" name="state" value="process" />
+   <input type="hidden" name="showphotos" value="1" />
+   <input type="hidden" name="photopermission" value="" />
   </form>
 ';
     } else {
@@ -2471,10 +2510,10 @@ sub print_photos_response {
                 if ($update) {
                     $response .= '<br />'.$commentary.'<br /><br />
 <form name="photoupdate" method="post">
-<input type ="button" name="retrieve" value="'.&mt('Update photo repository').'" 
+<input type="button" name="retrieve" value="'.&mt('Update photo repository').'" 
 onclick="javascript:document.photoupdate.submit()" /> 
-<input type ="hidden" name="action" value="'.$action.'" />
-<input type ="hidden" name="state" value="photoupdate" />
+<input type="hidden" name="action" value="'.$action.'" />
+<input type="hidden" name="state" value="photoupdate" />
 </form>';
                 }
 	    }