--- loncom/interface/statistics/lonsurveyreports.pm	2008/10/14 14:10:49	1.17
+++ loncom/interface/statistics/lonsurveyreports.pm	2008/12/12 05:03:39	1.22
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: lonsurveyreports.pm,v 1.17 2008/10/14 14:10:49 bisitz Exp $
+# $Id: lonsurveyreports.pm,v 1.22 2008/12/12 05:03:39 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -133,7 +133,10 @@ sub BuildSurveyReportsPage {
             $r->print('<h1>'.$resource->compTitle.'</h1>');
             $r->print('<h3>'.$resource->src.'</h3>');
             if ($env{'form.renderprob'} eq 'true') {
-                $r->print(&Apache::lonstathelpers::render_resource($resource));
+                $r->print('<hr />'
+                         .&Apache::lonstathelpers::render_resource($resource)
+                         .'<hr />'
+                );
             }
             $r->rflush();
             my %Data = &Apache::lonstathelpers::get_problem_data
@@ -201,17 +204,17 @@ sub SurveyProblemSelector {
               resptype=>undef});
         my $checked = '';
         if ($env{'form.problemchoice'} eq $value) {
-            $checked = 'checked ';
+            $checked = 'checked="checked" ';
         }
         my $link = $problem->{'res'}->link.
             '?symb='.&escape($problem->{'res'}->shown_symb);
         $Str .= '<tr><td>'.
             '<input type="radio" name="problemchoice" id="'.$id.'" '.
                    'value="'.$value.'" '.$checked.'/>'.'</td>'.
-            '<td><nobr>'.
+            '<td><span class="LC_nobreak">'.
             '<label for="'.$id.'">'.$problem->{'res'}->compTitle.' ('.$problem->{'seq'}->compTitle.')'.'</label>'.
             ('&nbsp;'x2).
-            '<a target="preview" href="'.$link.'">'.&mt('View survey').'</a>'.'</td></tr>'.$/;
+            '<a target="preview" href="'.$link.'">'.&mt('View survey').'</a></span></td></tr>'.$/;
     }
     $Str .= '</table>';
     return $Str;
@@ -336,7 +339,7 @@ sub make_text_report {
     } else {
         $r->print('<p class="LC_warning">'
                  .&mt('There is no essay or string response data to output for this survey.')
-                 .'</h2>');
+                 .'</p>');
     }
     $r->rflush();
     return;
@@ -566,15 +569,20 @@ sub make_HTML_report {
                             sprintf("%.2f",$count/$total*100).'%</td>'.
                         &Apache::loncommon::end_data_table_row().$/;
                 }
-                $Str .= &Apache::loncommon::start_data_table_row().
-                    '<th>'.&mt('Foil Name').'</th>'.
-                    '<th>'.&mt('Text').'</th>'.
-                    '<th>'.&mt('Freq').'</th>'.
-                    '<th>'.&mt('Percent').'</th>'.
-                    &Apache::loncommon::end_data_table_row().$/.
-                    $tmp;
+                $Str.='<tr>'
+                     .'<td colspan="3">'
+                     .&Apache::loncommon::start_data_table()
+                     .&Apache::loncommon::start_data_table_header_row()
+                     .'<th>'.&mt('Foil Name').'</th>'
+                     .'<th>'.&mt('Text').'</th>'
+                     .'<th>'.&mt('Frequency').'</th>'
+                     .'<th>'.&mt('Percent').'</th>'
+                     .&Apache::loncommon::end_data_table_header_row().$/
+                     .$tmp
+                     .&Apache::loncommon::end_data_table()
+                     .'</td></tr>';
             }
-            $Str.= &Apache::loncommon::end_data_table().'<hr />';
+            $Str.= '</table>';
             $r->print($Str);
             $r->rflush();
         }
@@ -613,23 +621,24 @@ sub CreateInterface {
                                 ) {
         $output_selector.='<option value="'.$output_format->{'name'}.'"';
         if ($env{'form.output'} eq $output_format->{'name'}) {
-            $output_selector.=' selected';
+            $output_selector.=' selected="selected"';
         }
         $output_selector.= '>'.$output_format->{'text'}.'</option>'.$/;
     }
     $output_selector .= '</select>'.$/;
     $Str .= &Apache::lonhtmlcommon::breadcrumbs('Student Submission Reports');
     $Str .= '<p>';
-    $Str .= '<table cellspacing="5">'."\n";
-    $Str .= '<tr>';
+    $Str .= &Apache::loncommon::start_data_table();
+    $Str .= &Apache::loncommon::start_data_table_header_row();
     $Str .= '<th>'.&mt('Sections').'</th>';
     $Str .= '<th>'.&mt('Groups').'</th>';
     $Str .= '<th>'.&mt('Access Status').'</th>';
     $Str .= '<th>'.&mt('Output Format').'</th>';
-    $Str .= '<th>'.'&nbsp;'.'</th>';
-    $Str .= '</tr>'."\n";
+    $Str .= '<th>'.&mt('Options').'</th>';
+    $Str .= &Apache::loncommon::end_data_table_header_row();
     #
-    $Str .= '<tr><td align="center">'."\n";
+    $Str .= &Apache::loncommon::start_data_table_row();
+    $Str .= '<td align="center">'."\n";
     $Str .= &Apache::lonstatistics::SectionSelect('Section','multiple',5);
     $Str .= '</td>';
     #
@@ -646,7 +655,7 @@ sub CreateInterface {
     # Render problem checkbox
     my $prob_checkbox = '<input type="checkbox" name="renderprob" ';
     if (exists($env{'form.renderprob'}) && $env{'form.renderprob'} eq 'true') {
-        $prob_checkbox .= 'checked ';
+        $prob_checkbox .= 'checked="checked" ';
     }
     $prob_checkbox .= 'value="true" />';
     $Str .= '<td align="right" valign="top">'.
@@ -655,13 +664,15 @@ sub CreateInterface {
         '<label><b>'.
         '</td>';
     #
-    $Str .= '</tr>'."\n";
-    $Str .= '</table>'."\n";
+    $Str .= &Apache::loncommon::end_data_table_row();
+    $Str .= &Apache::loncommon::end_data_table();
     #
-    $Str .= '<nobr>'.&mt('Status: [_1]',
-                         '<input type="text" '.
-                         'name="stats_status" size="60" value="" readonly="readonly" />').
-            '</nobr>'.'</p>';    
+    $Str .= '<p><span class="LC_nobreak">'
+           .&mt('Status: [_1]',
+                    '<input type="text" name="stats_status"'
+                   .' size="60" value="" readonly="readonly" />')
+           .'</span></p>';
+    $Str .= '</p>';
     ##
     return $Str;
 }